Review Request 119829: Add prettyFileName test for ProjectController and replace Project::open with ProjectController::openProject

[Dāvis Mosāns]

> On Aug. 18, 2014, 6:33 p.m., Dāvis Mosāns wrote:
> > shell/tests/projectcontrollertest.cpp, line 475
> > <https://git.reviewboard.kde.org/r/119829/diff/1/?file=306156#file306156line475>
> >
> >     It doesn't matter what scheme is used. Actually "kdev:/awesome.kdevinternal" is passed to prettyFileName and this just tests that some non-standart scheme works. It could be "kdev://" aswell.
> 
> Aleix Pol Gonzalez wrote:
>     Well, in the case of awesome.kdevinternal I wouldn't test it as it should be overriden. I added setTitle so we'd get "Dashboard" on the title, maybe it's missing a setPrettyName as well?

I'm not really sure what you mean. Basically because QUrl is used and passed to prettyFileName (like I noticed that kdev:// was passed) it must handle these cases where it's not just file, but can also be url with some scheme and it shouldn't break it. Thus this test.


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119829/#review64773
-----------------------------------------------------------


On Aug. 18, 2014, 5:57 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119829/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 5:57 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Add prettyFileName test for ProjectController and replace Project::open with ProjectController::openProject
> Using ProjectController::openProject because Project::open fails with assert
> 
> 
> Diffs
> -----
> 
>   shell/tests/projectcontrollertest.h 7c1cd09379592055301258c0d1cfc3492dafefcf 
>   shell/tests/projectcontrollertest.cpp c1bdb7646cae9cef9304e791793bd4b5d64ecaba 
> 
> Diff: https://git.reviewboard.kde.org/r/119829/diff/
> 
> 
> Testing
> -------
> 
> Test passes.
> 
> Well actually 2nd QCOMPARE in prettyFileName fails, but that's because current implementation is incorrect and it will pass once KUrl will be changed to QUrl
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140818/352d9d4f/attachment-0001.html>