Review Request 119829: Add prettyFileName test for ProjectController and replace Project::open with ProjectController::openProject

[Dāvis Mosāns]

> On Aug. 18, 2014, 6:15 p.m., Aleix Pol Gonzalez wrote:
> > shell/tests/projectcontrollertest.cpp, line 255
> > <https://git.reviewboard.kde.org/r/119829/diff/1/?file=306156#file306156line255>
> >
> >     WAIT_FOR_OPEN_SIGNAL should do this, no?
> >     
> >     Anyway you have the projectOpened signal and the Project::isReady method to do so.

Idea of reopenWhileLoading test is that you open project and open same project again while first one is still beeing opened.
In previous implementation it was that 2nd openProject would return false. But now, openProject doesn't return anything, so trying to call it 2nd time, it will just fail.


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119829/#review64771
-----------------------------------------------------------


On Aug. 18, 2014, 5:57 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119829/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 5:57 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Add prettyFileName test for ProjectController and replace Project::open with ProjectController::openProject
> Using ProjectController::openProject because Project::open fails with assert
> 
> 
> Diffs
> -----
> 
>   shell/tests/projectcontrollertest.h 7c1cd09379592055301258c0d1cfc3492dafefcf 
>   shell/tests/projectcontrollertest.cpp c1bdb7646cae9cef9304e791793bd4b5d64ecaba 
> 
> Diff: https://git.reviewboard.kde.org/r/119829/diff/
> 
> 
> Testing
> -------
> 
> Test passes.
> 
> Well actually 2nd QCOMPARE in prettyFileName fails, but that's because current implementation is incorrect and it will pass once KUrl will be changed to QUrl
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140818/e45a62d2/attachment.html>