Review Request 119829: Add prettyFileName test for ProjectController and replace Project::open with ProjectController::openProject

Dāvis Mosāns davispuh at gmail.com
Mon Aug 18 14:59:49 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119829/#review64768
-----------------------------------------------------------



shell/tests/projectcontrollertest.cpp
<https://git.reviewboard.kde.org/r/119829/#comment45299>

    I commented this out in previous patch, because don't know how to check if project is beeing oppened.


- Dāvis Mosāns


On Aug. 18, 2014, 5:57 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119829/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 5:57 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Add prettyFileName test for ProjectController and replace Project::open with ProjectController::openProject
> Using ProjectController::openProject because Project::open fails with assert
> 
> 
> Diffs
> -----
> 
>   shell/tests/projectcontrollertest.h 7c1cd09379592055301258c0d1cfc3492dafefcf 
>   shell/tests/projectcontrollertest.cpp c1bdb7646cae9cef9304e791793bd4b5d64ecaba 
> 
> Diff: https://git.reviewboard.kde.org/r/119829/diff/
> 
> 
> Testing
> -------
> 
> Test passes.
> 
> Well actually 2nd QCOMPARE in prettyFileName fails, but that's because current implementation is incorrect and it will pass once KUrl will be changed to QUrl
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140818/c2caefc3/attachment.html>


More information about the KDevelop-devel mailing list