Review Request 119795: fix bug 337282 : Consistent naming scheme for unit test

Kevin Funk kfunk at kde.org
Mon Aug 18 12:51:24 UTC 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119795/#review64742
-----------------------------------------------------------


Hey Laurent,

looks good, but please make use of the (relatively new) *ecm_add_tests* macro from extra-cmake-modules.git, as I mentioned on IRC. This reduces about 3-4 lines of CMake code per test executable.

- Kevin Funk


On Aug. 14, 2014, 8:55 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119795/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 8:55 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Bugs: 337282
>     http://bugs.kde.org/show_bug.cgi?id=337282
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> rename .cpp .h and target from footest or whatever to test_foo
> rename class from FooTest to TestFoo
> adapt headers guardians if needed
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/tests/CMakeLists.txt da80212 
>   vcs/dvcs/tests/dvcsjobTest.h 3f3287e 
>   vcs/dvcs/tests/dvcsjobTest.cpp c375840 
>   vcs/dvcs/tests/test_dvcsjob.h PRE-CREATION 
>   vcs/dvcs/tests/test_dvcsjob.cpp PRE-CREATION 
>   vcs/models/tests/CMakeLists.txt a359493 
>   vcs/models/tests/modelstest.h bab997f 
>   vcs/models/tests/modelstest.cpp b23876e 
>   vcs/models/tests/test_models.h PRE-CREATION 
>   vcs/models/tests/test_models.cpp PRE-CREATION 
>   sublime/tests/areaoperationtest.cpp b99415b 
>   sublime/tests/areaprinter.h f7911b2 
>   sublime/tests/areawalkertest.h 1fa7eed 
>   sublime/tests/areawalkertest.cpp d56f06a 
>   sublime/tests/controllertest.h 0b4fff5 
>   sublime/tests/controllertest.cpp 39d527b 
>   sublime/tests/documenttest.h 7d8692c 
>   sublime/tests/documenttest.cpp 36e8c3d 
>   sublime/tests/test_aggregatemodel.h PRE-CREATION 
>   sublime/tests/test_aggregatemodel.cpp PRE-CREATION 
>   sublime/tests/test_areaoperation.h PRE-CREATION 
>   sublime/tests/test_areaoperation.cpp PRE-CREATION 
>   sublime/tests/test_areawalker.h PRE-CREATION 
>   sublime/tests/test_areawalker.cpp PRE-CREATION 
>   sublime/tests/test_controller.h PRE-CREATION 
>   sublime/tests/test_controller.cpp PRE-CREATION 
>   sublime/tests/test_document.h PRE-CREATION 
>   sublime/tests/test_document.cpp PRE-CREATION 
>   sublime/tests/test_toolviewtoolbar.h PRE-CREATION 
>   sublime/tests/test_toolviewtoolbar.cpp PRE-CREATION 
>   sublime/tests/test_view.h PRE-CREATION 
>   sublime/tests/test_view.cpp PRE-CREATION 
>   sublime/tests/test_viewactivation.h PRE-CREATION 
>   sublime/tests/test_viewactivation.cpp PRE-CREATION 
>   sublime/tests/toolviewtoolbartest.h 7fb95f6 
>   sublime/tests/toolviewtoolbartest.cpp d2d222d 
>   sublime/tests/viewactivationtest.h 2a3b5b4 
>   sublime/tests/viewactivationtest.cpp 7b15414 
>   sublime/tests/viewtest.h b6e67b2 
>   sublime/tests/viewtest.cpp 9debb6b 
>   tests/modeltest.cpp a22b635 
>   util/tests/CMakeLists.txt 896a4ad 
>   shell/tests/testcontrollertest.h e7d5ca0 
>   shell/tests/testcontrollertest.cpp de58600 
>   shell/tests/uicontrollertest.h 2481f74 
>   shell/tests/uicontrollertest.cpp dc8b80a 
>   sublime/tests/CMakeLists.txt c3d487e 
>   sublime/tests/aggregatemodeltest.h d5e92b0 
>   sublime/tests/aggregatemodeltest.cpp 0ed7d6b 
>   sublime/tests/areaoperationtest.h fde0b8c 
>   shell/tests/test_uicontroller.cpp PRE-CREATION 
>   interfaces/tests/CMakeLists.txt d7c68b7 
>   language/backgroundparser/tests/CMakeLists.txt d97ac73 
>   language/codegen/tests/CMakeLists.txt 844eb90 
>   language/duchain/tests/CMakeLists.txt 84a7ac1 
>   language/duchain/tests/benchhashes.h f3fabfc 
>   language/duchain/tests/benchhashes.cpp 2da3589 
>   language/duchain/tests/test_benchhashes.h PRE-CREATION 
>   language/duchain/tests/test_benchhashes.cpp PRE-CREATION 
>   language/duchain/tests/test_duchainshutdown.h PRE-CREATION 
>   language/duchain/tests/test_duchainshutdown.cpp PRE-CREATION 
>   language/duchain/tests/tst_duchainshutdown.h 1a47ae7 
>   language/duchain/tests/tst_duchainshutdown.cpp c1a6323 
>   language/highlighting/tests/CMakeLists.txt c2710c7 
>   plugins/git/tests/CMakeLists.txt f3e6d87 
>   plugins/git/tests/gittest.h 4199854 
>   plugins/git/tests/gittest.cpp ea91a4c 
>   plugins/git/tests/test_git.h PRE-CREATION 
>   plugins/git/tests/test_git.cpp PRE-CREATION 
>   plugins/grepview/tests/CMakeLists.txt e6143de 
>   plugins/grepview/tests/findreplacetest.h 309df44 
>   plugins/grepview/tests/findreplacetest.cpp 53255e3 
>   plugins/grepview/tests/test_findreplace.h PRE-CREATION 
>   plugins/grepview/tests/test_findreplace.cpp PRE-CREATION 
>   plugins/projectfilter/tests/CMakeLists.txt 6c18ff9 
>   plugins/quickopen/tests/CMakeLists.txt 08b94ba 
>   plugins/quickopen/tests/quickopenbench.h 14f01d3 
>   plugins/quickopen/tests/quickopenbench.cpp 912b0ad 
>   plugins/quickopen/tests/quickopentest.h f0148eb 
>   plugins/quickopen/tests/quickopentest.cpp 0f69a5e 
>   plugins/quickopen/tests/test_quickopen.h PRE-CREATION 
>   plugins/quickopen/tests/test_quickopen.cpp PRE-CREATION 
>   plugins/quickopen/tests/test_quickopenbench.h PRE-CREATION 
>   plugins/quickopen/tests/test_quickopenbench.cpp PRE-CREATION 
>   plugins/standardoutputview/tests/CMakeLists.txt 58234c0 
>   plugins/standardoutputview/tests/standardoutputviewtest.h 92ef213 
>   plugins/standardoutputview/tests/standardoutputviewtest.cpp d48fb84 
>   plugins/standardoutputview/tests/test_standardoutputview.h PRE-CREATION 
>   plugins/standardoutputview/tests/test_standardoutputview.cpp PRE-CREATION 
>   project/tests/CMakeLists.txt ab7fdf6 
>   project/tests/projectmodeltest.h 7301b72 
>   project/tests/projectmodeltest.cpp 1ba4cce 
>   project/tests/test_projectmodel.h PRE-CREATION 
>   project/tests/test_projectmodel.cpp PRE-CREATION 
>   serialization/tests/CMakeLists.txt 6345328 
>   shell/tests/CMakeLists.txt a5c3832 
>   shell/tests/documentcontrollertest.h 86462a4 
>   shell/tests/documentcontrollertest.cpp 1edcf4a 
>   shell/tests/plugincontrollertest.h a318bea 
>   shell/tests/plugincontrollertest.cpp 72ec0f0 
>   shell/tests/sessioncontrollertest.h 3230b09 
>   shell/tests/sessioncontrollertest.cpp e397e37 
>   shell/tests/shellbuddytest.h 7f92f0e 
>   shell/tests/shellbuddytest.cpp 7ef62cc 
>   shell/tests/shelldocumentoperationtest.h f70ed6b 
>   shell/tests/shelldocumentoperationtest.cpp 20798cc 
>   shell/tests/test_documentcontroller.h PRE-CREATION 
>   shell/tests/test_documentcontroller.cpp PRE-CREATION 
>   shell/tests/test_plugincontroller.h PRE-CREATION 
>   shell/tests/test_plugincontroller.cpp PRE-CREATION 
>   shell/tests/test_sessioncontroller.h PRE-CREATION 
>   shell/tests/test_sessioncontroller.cpp PRE-CREATION 
>   shell/tests/test_shellbuddy.h PRE-CREATION 
>   shell/tests/test_shellbuddy.cpp PRE-CREATION 
>   shell/tests/test_shelldocumentoperation.h PRE-CREATION 
>   shell/tests/test_shelldocumentoperation.cpp PRE-CREATION 
>   shell/tests/test_testcontroller.h PRE-CREATION 
>   shell/tests/test_testcontroller.cpp PRE-CREATION 
>   shell/tests/test_uicontroller.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119795/diff/
> 
> 
> Testing
> -------
> 
> make && ctest
> 
> some tests are failing, but certainly due to my setup
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140818/2da44d75/attachment.html>

More information about the KDevelop-devel mailing list