Review Request 119757: kde4_add_plugin and kde4_install_icons is deprecated

Aleix Pol Gonzalez aleixpol at kde.org
Wed Aug 13 14:06:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119757/#review64473
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Aug. 13, 2014, 12:22 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119757/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 12:22 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> kde4_add_plugin and kde4_install_icons is deprecated so replace those and update to new syntax.
> 
> 
> Diffs
> -----
> 
>   plugins/bazaar/CMakeLists.txt e7bd1585c9796b3f0af8b749d69d83683a93ccc2 
>   plugins/bazaar/icons/CMakeLists.txt 02e3c9ecf2e80622b6cb3a816c89cba556b500a8 
>   plugins/bazaar/icons/hi128-app-bazaar.png  
>   plugins/git/icons/CMakeLists.txt b60fd9253dfcbf6a8fa9e578989a91cdd3f8051f 
>   plugins/git/icons/hi16-app-git.png  
>   plugins/git/icons/hi32-app-git.png  
>   plugins/git/icons/hi64-app-git.png  
>   plugins/reviewboard/icons/CMakeLists.txt 170ecc74fa280d612765b92ef0a2d8c02be696ce 
>   plugins/reviewboard/icons/hi128-app-reviewboard.png  
>   plugins/reviewboard/icons/hi16-app-reviewboard.png  
>   plugins/subversion/icons/CMakeLists.txt b60fd9253dfcbf6a8fa9e578989a91cdd3f8051f 
>   plugins/subversion/icons/hi16-app-subversion.png  
>   plugins/subversion/icons/hi32-app-subversion.png  
>   plugins/subversion/icons/hi64-app-subversion.png  
>   plugins/subversion/icons/hisc-app-subversion.svg  
> 
> Diff: https://git.reviewboard.kde.org/r/119757/diff/
> 
> 
> Testing
> -------
> 
> No warnings for CMake anymore.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140813/78ef68f7/attachment.html>


More information about the KDevelop-devel mailing list