Review Request 119709: Fix another build failure originating from GCC-4.7 bug.

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119709/#review64385
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Funk


On Aug. 11, 2014, 10 a.m., Craig T. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119709/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 10 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Owing to a bug in GCC versions less than the 4.8, we encounter the following build failure when compiling kdevelop with GCC-4.7:
> 
> `KDevelop/projectmanagers/custommake/custommakemanager.cpp:46:7: error: looser throw specifier for ‘virtual CustomMakeProvider::~CustomMakeProvider()’
> In file included from KDevelop/projectmanagers/custommake/custommakemanager.cpp:41:0:
> KDevelop/projectmanagers/custommake/../../languages/plugins/custom-definesandincludes/idefinesandincludesmanager.h:96:17: error:   overriding ‘virtual KDevelop::IDefinesAndIncludesManager::BackgroundProvider::~BackgroundProvider() noexcept (true)’`
> 
> The GCC bugzilla (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53613) suggests a single workaround in this particular instance: adding a definition to the destructor outside the class definition.
> 
> This fix was prompted by several callers to #kdevelop whom all seemed to be running afoul of this issue. As GCC-4.7 is still in moderate use, it may be worth it to just bite the bullet and apply this for now. I still lack commit access and would be happily credited as "Craig Tenenbaum" <zarathustra.zoroaster at gmail.com>
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custommake/custommakemanager.cpp 8440785 
> 
> Diff: https://git.reviewboard.kde.org/r/119709/diff/
> 
> 
> Testing
> -------
> 
> Compiled against GCC-4.7.3
> 
> 
> Thanks,
> 
> Craig T.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140812/95cbf8af/attachment.html>