Review Request 119708: Don't try to reparse translation unit.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119708/#review64364
-----------------------------------------------------------


This looks really wrong (and bad, from a performance pov). Please try to understand whats going on. My bet:

clang_createIndex(1 /*Exclude PCH Decls*/, ...

see clangindex.cpp

- Milian Wolff


On Aug. 11, 2014, 8:29 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119708/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 8:29 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> It just doesn't work.
> E.g. after repasing clang reports that there are no imports at all, except the file itself), but clang_reparseTranslationUnit returns 0 => everything is ok...
> 
> See also testReparseInclude unit test.
> 
> 
> Diffs
> -----
> 
>   duchain/parsesession.cpp e899eca 
>   tests/test_duchain.h 7844c17 
>   tests/test_duchain.cpp 563de7a 
> 
> Diff: https://git.reviewboard.kde.org/r/119708/diff/
> 
> 
> Testing
> -------
> 
> Added an unit test for it.
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140812/2ab201d7/attachment-0001.html>