Review Request 119693: port away from KGlobalSettings::kdisplayPaletteChanged()
Milian Wolff
mail at milianw.de
Sun Aug 10 13:09:58 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119693/#review64167
-----------------------------------------------------------
No, please don't. I'd rather have a warning than silently unfunctional code. Once we have a working alternative I'd be willing to accept it.
- Milian Wolff
On Aug. 10, 2014, 1:04 p.m., Dominik Haumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119693/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2014, 1:04 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Port to QEvent::ApplicationPaletteChanged, the same way we do this in Kate.
> Unfortuantely, this event is never sent in Kate/KWrite, so this might also not work here. It may still be a better port than the KF5 warning.
>
>
> Diffs
> -----
>
> debuggers/gdb/gdboutputwidget.h e3bf3cd
> debuggers/gdb/gdboutputwidget.cpp d2ed23c
>
> Diff: https://git.reviewboard.kde.org/r/119693/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Dominik Haumann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140810/a2196599/attachment.html>
More information about the KDevelop-devel
mailing list