Review Request 119686: Introduce kdevplatformrepositories

Milian Wolff mail at milianw.de
Sat Aug 9 20:20:09 UTC 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119686/#review64127
-----------------------------------------------------------

Ship it!


Awesome work - many thanks for that! I'd say reformat all moved files while at it (clang-format, uncrustify or astyle).

Also, I'd personally prefer the folder and library to be called serialization since thats what its about. But if its too much work (the gain is minimal), don't worry about that and keep repositories as name.


repositories/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119686/#comment44780>

    I'd put the LINK_PUBLIC on its own line, like you did with the LINK_PRIVATE.



repositories/abstractitemrepository.h
<https://git.reviewboard.kde.org/r/119686/#comment44782>

    could you please reformat the file while at it?



repositories/abstractitemrepository.h
<https://git.reviewboard.kde.org/r/119686/#comment44781>

    this is dead code, could you remove it while at it please?



repositories/indexedstring.h
<https://git.reviewboard.kde.org/r/119686/#comment44784>

    while at, please reformat this file, or well - actually run it on all moved files.



repositories/indexedstring.h
<https://git.reviewboard.kde.org/r/119686/#comment44783>

    while at it:
    
    the reference counting logic. Never store pure indices to disk.


- Milian Wolff


On Aug. 9, 2014, 7:53 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119686/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2014, 7:53 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Introduce kdevplatformrepositories
> 
> The idea is to have a separate component that contains all the infrastructure needed for building your item registry.
> Plus, store generally useful repositories here (such as the StringRepository/IndexedString combo).
> 
> This helps to decouple IndexedString from kdevplatformlanguage.
> 
> 
> Diffs
> -----
> 
>   repositories/tests/CMakeLists.txt PRE-CREATION 
>   repositories/tests/serialization/CMakeLists.txt PRE-CREATION 
>   repositories/tests/serialization/tst_indexedstring.h PRE-CREATION 
>   repositories/tests/serialization/tst_indexedstring.cpp PRE-CREATION 
>   repositories/tests/serialization/tst_itemrepository.h PRE-CREATION 
>   repositories/tests/serialization/tst_itemrepository.cpp PRE-CREATION 
>   repositories/tests/test_itemrepository.h PRE-CREATION 
>   repositories/itemrepository.h PRE-CREATION 
>   repositories/itemrepositoryexampleitem.h PRE-CREATION 
>   repositories/itemrepositoryregistry.h PRE-CREATION 
>   repositories/itemrepositoryregistry.cpp PRE-CREATION 
>   repositories/referencecounting.h PRE-CREATION 
>   repositories/referencecounting.cpp PRE-CREATION 
>   plugins/classbrowser/classtree.cpp 151a964201d4a7b4fc5add750e49eeb80ee5a6d8 
>   plugins/problemreporter/watcheddocumentset.h 6805a97e48ab5fdd90996715f80f307fd20bf377 
>   plugins/quickopen/duchainitemquickopen.cpp c4c1576d343f3b580d4ed5bcdeba5919104beb98 
>   plugins/quickopen/projectfilequickopen.h 5e79058496681088a96c9041a492732e809b9cd1 
>   plugins/quickopen/projectfilequickopen.cpp 049d40a3ad2dbf233faf9403aa8ea623dae85542 
>   plugins/quickopen/projectitemquickopen.h 9f723be1b67b44d7318585d532be22d8269eeee1 
>   plugins/quickopen/quickopenmodel.h f9a0ae3f96d4ff3e697d45e5c0e4cc6630b9daa2 
>   plugins/quickopen/quickopenplugin.cpp 2c937d131bb707043c9006a5e482caeab14619e4 
>   plugins/classbrowser/projectfolder.cpp 1c386dd30347729c5152314698714dd4fe58bd16 
>   plugins/contextbrowser/contextbrowserview.h 4b7f000e8bdc16a662f22e507ff9560190d83376 
>   plugins/contextbrowser/contextbrowserview.cpp 0c3ef2e575c87a69e3c7e4d0aa595d143eac91b3 
>   plugins/grepview/grepfindthread.cpp c10f4b8a706927adc0dbdaecace31e7ee2dfd110 
>   plugins/grepview/grepjob.cpp a1dc2fc78e25ffc2ac646690846f62460e2c95da 
>   plugins/problemreporter/problemhighlighter.cpp 46727e8c7c5d01502c5fe8a4525857500d99b87f 
>   plugins/problemreporter/problemreporterplugin.h 88746eb09d9b85c97bcd14149e1d0d4fcdcff134 
>   language/highlighting/codehighlighting.h 6a9730510d1dfd7b00fed4920abc836c793f239c 
>   language/util/basicsetrepository.h 5b4c683c4a2b58d6acdf71164e0f9c7e136149fc 
>   language/editor/modificationrevision.cpp 841d5f379339459103a7a5eb918c640c56a308d0 
>   language/editor/modificationrevisionset.cpp 484511708664cb70d3ea692614824a407bc0b7ac 
>   language/editor/documentrange.h fc2b1727a85e6bbc4bfcb322bb67e5eed064b20b 
>   language/duchain/types/typesystem.cpp 7727640393276e9eeee2eaa91ea8ab2961f20b00 
>   language/duchain/types/typesystemdata.h b3c99dfa2242fddcb4cdc6f68214a2feaa6f15d1 
>   language/duchain/waitforupdate.h 37ace42babe977f78526384b7211455711419c21 
>   language/editor/documentcursor.h 04c4866adc731b237d86579ce9c5870a4f4f1808 
>   language/duchain/types/structuretype.cpp 807b706649de70eaf886c0e774c60f7cfa11cff2 
>   language/duchain/types/typerepository.h PRE-CREATION 
>   language/duchain/types/typerepository.cpp PRE-CREATION 
>   language/duchain/tests/test_itemrepository.cpp 6c0bacd0b6f10c52f66b0b6b0959309a26f1754f 
>   language/duchain/tests/test_itemrepositoryregistry_automatic.cpp e3bba3da52ffab93b9055de7e86dc42d40ab9857 
>   language/duchain/tests/test_itemrepositoryregistry_deferred.cpp e6c5ab70a1a35e09477efe3be1b392c65d2db852 
>   language/duchain/tests/tst_identifier.h PRE-CREATION 
>   language/duchain/tests/tst_identifier.cpp PRE-CREATION 
>   language/duchain/topducontextdata.h 5313eb0bde7f2572b4f2b8da49703d62cb08ac31 
>   language/duchain/types/abstracttype.cpp 6aeeb955746f5e2f99e04fb5fded5ffb968fa1d1 
>   language/duchain/types/arraytype.cpp 31c371fc3c0ee1ec7be799471f4fe165fca00bb9 
>   language/duchain/types/delayedtype.cpp affff09e4b8a83524d50201550be84fb0790ba5e 
>   language/duchain/types/functiontype.cpp 7c4a1f6b3265b8ba6958a86ac833f0542981b823 
>   language/duchain/types/indexedtype.h 9dcfe31bc03f18c22fe770f8fdab9ad1e01c2cee 
>   language/duchain/types/indexedtype.cpp 7e5d6f2d31721614e819fd4b8c49f863651f4f74 
>   language/duchain/types/integraltype.cpp a3309f4c73746b75073622132a88bd91552f307f 
>   language/duchain/types/pointertype.cpp 36260be05437a53cd4d90e4daf8776dc34dd9cb7 
>   language/duchain/types/referencetype.cpp b5bd5789c3a4aaa13ce6a015958bfe2d5fcb31ed 
>   plugins/classbrowser/classmodelnodescontroller.h 220c93d5f6ff6628f3712dad4cae074761988db5 
>   language/duchain/tests/serialization/tst_itemrepository.cpp c9f4fdc9294ac73f8c1051cf9f55200877046f8b 
>   language/duchain/tests/test_itemrepository.h e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   project/abstractfilemanagerplugin.cpp b9379b92f84118c7345ef637196d5c5d177ab12e 
>   project/projectmodel.cpp 7470429a7d7876f513c90e8dc40ac2131fab47b6 
>   repositories/tests/test_itemrepository.cpp PRE-CREATION 
>   repositories/tests/test_itemrepositoryregistry_automatic.cpp PRE-CREATION 
>   repositories/tests/test_itemrepositoryregistry_deferred.cpp PRE-CREATION 
>   shell/project.cpp 648c391186874ebec024d37977c1bbf759694497 
>   shell/session.cpp 8df96a88b254983558a6770de51e2551af55d6c5 
>   shell/sessioncontroller.cpp 838894850c7999cf1880c7dd1f0db12dc42eea09 
>   tests/testproject.h f4a59efa3aac7bc21ee5b610e435e8a7942574a3 
>   vcs/vcspluginhelper.cpp 2379709ecb6b1facedc46c02452c743e4159b45a 
>   repositories/repositorymanager.h PRE-CREATION 
>   repositories/stringrepository.h PRE-CREATION 
>   repositories/CMakeLists.txt PRE-CREATION 
>   repositories/abstractitemrepository.h PRE-CREATION 
>   repositories/abstractitemrepository.cpp PRE-CREATION 
>   repositories/indexedstring.h PRE-CREATION 
>   repositories/indexedstring.cpp PRE-CREATION 
>   language/duchain/tests/serialization/tst_itemrepository.h ba9e44175bde292215a1c292a63a809c9d061e49 
>   language/duchain/tests/serialization/tst_indexedstring.h 4460fedae9323d64ac2a93a4bac17b0a882c001f 
>   language/duchain/tests/serialization/tst_indexedstring.cpp c58ace3393d4f105c22d94c720031ffee857372d 
>   language/util/setrepository.h d4644b2a7565f41d1f4f8757ab34ddfb98fb4958 
>   language/util/setrepository.cpp f92040152954f8c8b1024ef5cdf91c32d68002cc 
>   plugins/classbrowser/classbrowserplugin.cpp cba2ddf5a6421399d93760c449eb8d9f440f1a05 
>   language/duchain/tests/serialization/tst_identifier.cpp 5268bd90e20cad6b095a85ca9399cf27230e4b9b 
>   language/duchain/tests/serialization/CMakeLists.txt 82d42ddc613b487506a5365b0923ccd3e82c434d 
>   language/duchain/tests/serialization/tst_identifier.h 045e42431e57156deb524f4ffbacb557318a0e5c 
>   language/duchain/repositories/abstractitemrepository.cpp 1459034a2d55c419cc37e262f4ef0bc5de5f7907 
>   language/duchain/repositories/itemrepository.h 1f5e9064ba7f363858c393e655be82a3163f3cca 
>   language/duchain/repositories/itemrepositoryexampleitem.h 1d3bdef01defef7eaeba0bbd0a8ee9430f8f06f2 
>   language/duchain/repositories/itemrepositoryregistry.h b1b795bc42b33404610190925eb8f60690a6c739 
>   language/duchain/repositories/itemrepositoryregistry.cpp aae3e8054be3b284424328eaec6104bdb3a0b2c0 
>   language/duchain/repositories/repositorymanager.h 75d99f33e691d33396f249cc1f9e68f88e308f2d 
>   language/duchain/repositories/stringrepository.h 94ae6b4f5c333a959a5cab75953874b5e2db6f82 
>   language/duchain/repositories/typerepository.h 12285c41713044d19c46017e3f2bcd7ab7f91d75 
>   language/duchain/repositories/typerepository.cpp 323d5a597d2c06f296abea789110cdfa377e76be 
>   language/duchain/tests/CMakeLists.txt b52d5ba54c418e59e669b091a5ff8870ff53f646 
>   language/duchain/tests/benchhashes.cpp 0bf66acc82495a42c8b6b030c484a3028538e604 
>   language/codegen/coderepresentation.cpp 44792ac1c2c09c3514f4b980d10d4d1f8e06990c 
>   language/codegen/documentchangeset.h 36cd1721811e55e70bf2a6a0549b88bd6d28674e 
>   language/codegen/progressdialogs/refactoringdialog.cpp 1e9ffc88b02b68123ee3a2d97d3b566b3f28ab67 
>   language/codegen/templaterenderer.cpp 30421c17311e144b82aecdf9efc793772a74fe43 
>   language/codegen/utilities.cpp ee50706d54867d8a440bd7126ce3e590c82d0fe3 
>   language/duchain/abstractfunctiondeclaration.cpp 3a3be14d864ac5e69cadc9df62a3383a492bb14a 
>   language/duchain/appendedlist_static.h d76ca19757d6bb093cec6341df72508faeb69f4d 
>   language/duchain/classdeclaration.cpp c1c2fac165a9e35348e2100df3cec643b2d18628 
>   language/duchain/codemodel.cpp 35bde270852b296324db775e17a5982ddb3178a4 
>   language/duchain/declaration.cpp 423555479ec41439f0d232f96e775c3583a4f7f8 
>   language/duchain/definitions.cpp 5b4c38215ef4a2814c2a13a8dc3b05ed3dca3f33 
>   language/duchain/duchain.cpp 9952343b94ada5c76669f7859bc296611490fc8b 
>   language/duchain/duchainbase.cpp a77428457b9f7f2ca7f90b1e87df0583b8458c7b 
>   language/duchain/duchaindumper.cpp e87f2242286165c108caf15983cd0066a32b05a9 
>   language/duchain/ducontext.cpp 10d455a682a91a2f815ea18fda12fe5a66fb84ae 
>   language/duchain/identifier.h 292f10d7a47700e595ff56d2a485b091d1381e3a 
>   language/duchain/identifier.cpp 20aec4b330f09d5865b62616416e45916fe59dad 
>   language/duchain/indexedstring.h 8c74c34efabbe368f271b8751eb0a80a5c09479f 
>   language/duchain/indexedstring.cpp 7f2ceb81c2f2b2173b4e2dd9531e50781cfc1e86 
>   language/duchain/instantiationinformation.h 136db1b4e67f4d229de5362e46d80f0188e82ebe 
>   language/duchain/instantiationinformation.cpp 027f6769fe97c01cd027f70fd4146cbb2ad40c03 
>   language/duchain/navigation/usescollector.h 91d00dd5c3313f851f2921ac16fae174fa3072da 
>   language/duchain/parsingenvironment.h 647b8e2174f8b76e80b4742edbd7736e12a33a36 
>   language/duchain/problem.h e1f56379ce9cc11021137acfa90fa5757ac1a0db 
>   language/duchain/referencecounting.h c396bca52e483980ec3bdc6d219c744254579c0b 
>   language/duchain/referencecounting.cpp ab3fc2bccb27951036c1cc7d132f9f7f6a1671ef 
>   language/duchain/repositories/abstractitemrepository.h 51c907ff4dd724593f3c016575e4e5627b920dd8 
>   language/assistant/renameassistant.h bc898a432b7e020b0c744bea34635ef6c217ba93 
>   language/assistant/staticassistantsmanager.h 4e59e1516716b45423e305ace89c28173b0adabd 
>   language/backgroundparser/documentchangetracker.h c7d4ba22e6a0a68f830c33e5de007b3f211ee8e1 
>   language/backgroundparser/documentchangetracker.cpp e84c952bfe942747d7b936de85c62508a2531bb2 
>   language/backgroundparser/parsejob.h 36e79eb9861603ddf53dc310ac18850388bf45b8 
>   language/backgroundparser/parseprojectjob.h ae23d6da570bbfb5ca34137b8d241d7ae8684150 
>   language/backgroundparser/tests/test_backgroundparser.h 4e5e837e8de524ec536a13edba34c0aa7c455311 
>   language/backgroundparser/urlparselock.h e0d310922412532a2e898b25088117026142d1dd 
>   language/codegen/codegenerator.h 8f5d57c75233d7dab2da894c5cdc3127f69dae35 
>   language/codegen/coderepresentation.h 605ab845feea78a462e9417114f0dc29b7378f5e 
>   CMakeLists.txt 8ec8e97dbdb8fa295e89a67a7ffc7475b06c512e 
>   KDevPlatformConfig.cmake.in 5eb91a0d6e6d5b01df9341b375aa84723c32e29c 
>   language/CMakeLists.txt e40eab5d27ea80ddca423e803bd94915113dc9e1 
>   language/assistant/renameaction.h d613400353d9e68e32ff6419c10a049fd2eb3ccd 
> 
> Diff: https://git.reviewboard.kde.org/r/119686/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140809/41a0edb2/attachment-0001.html>

More information about the KDevelop-devel mailing list