Review Request 115095: Add initial support for CMake APPEND_STRING.

[Ben Wagner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115095/
-----------------------------------------------------------

(Updated Aug. 8, 2014, 10:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdevelop


Description
-------

With CMake 2.8.6 there was added an APPEND_STRING option to set_property. In CMake, APPEND appends a ';' to the existing value (when it exists and is non-empty). APPEND_STRING does not append this ';'. This was a simple change in CMake, but adds another odd corner case to KDevelop.

The parser in CMake will simply hold all appends as a string, and parse that string to a list as needed. In KDevelop the value is always held as a list, so the odd case (which is possible in CMake) where an individual list value is created over multiple commands is not easily emulated in the KDevelop parser.

Seeing as full support is a rather large change, this change simply makes APPEND_STRING an alias for APPEND in KDevelop which handles almost all cases.

This will probably need a test, and this may or may not be the best way to do this, but it seems better than failing to parse the set_properties command at all.


Diffs
-----

  projectmanagers/cmake/parser/cmakeast.cpp aac1070 

Diff: https://git.reviewboard.kde.org/r/115095/diff/


Testing
-------

Built. Seems to work ok. Probably needs a real test.


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140808/6adeba2a/attachment.html>