Review Request 119642: Make opened files be parsed properly
Milian Wolff
mail at milianw.de
Fri Aug 8 09:12:13 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119642/#review64037
-----------------------------------------------------------
Ship it!
once the issue below is fixed, I'm fine with this going in. but please put it into the 1.7 branch.
shell/projectcontroller.cpp
<https://git.reviewboard.kde.org/r/119642/#comment44678>
should this do exactly the same as the project parse job, namely prefer the active document with highest priority?
and: could we share some code between the two places then?
- Milian Wolff
On Aug. 7, 2014, 1:31 p.m., Sergey Kalinichev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119642/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 1:31 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> First queue active document with highest priority, then currently opened files and everything else. That way we get active document parsed first of all.
> Also forcefully reparse all opened files to make sure they have valid include directories (otherwise sometimes those files won't be parsed properly)
>
>
> Diffs
> -----
>
> language/backgroundparser/parseprojectjob.cpp 7f430d7
> shell/projectcontroller.cpp 994a737
>
> Diff: https://git.reviewboard.kde.org/r/119642/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Kalinichev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140808/3195be5e/attachment-0001.html>
More information about the KDevelop-devel
mailing list