Review Request 119642: Make opened files be parsed properly

[Sergey Kalinichev]

> On Aug. 7, 2014, 4:30 p.m., Milian Wolff wrote:
> > Ah sorry, now that I think more about this, the forced update is _wrong_
> > 
> > You probably saw this when using kdev-clang, right? The bug is there, it does not check the old environment vs. the new one and then thinks no update is required. Always forcing an update of all opened files will be slow and we do not want to do that.
> 
> Milian Wolff wrote:
>     note: the rest of this patch is OK, i.e. preferring to first update the active document, then the opened ones, then the others.

>You probably saw this when using kdev-clang, right?

Yes, but it happens with oldcpp too. E.g. sometimes after opening the project it can't find include directories/some declarations. But reloading the document manually helps.

>the forced update is wrong

Yes I know it's not a proper solution, let's keep on using the old approach then.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119642/#review63979
-----------------------------------------------------------


On Aug. 7, 2014, 2:33 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119642/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 2:33 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> First queue active document with highest priority, then currently opened files and everything else. That way we get active document parsed first of all.
> Also forcefully reparse all opened files to make sure they have valid include directories (otherwise sometimes those files won't be parsed properly)
> 
> 
> Diffs
> -----
> 
>   language/backgroundparser/parseprojectjob.cpp 7f430d7 
>   shell/projectcontroller.cpp 994a737 
> 
> Diff: https://git.reviewboard.kde.org/r/119642/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140807/dcb9ef29/attachment.html>