Review Request 119642: Make opened files be parsed properly

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119642/#review63978
-----------------------------------------------------------



language/backgroundparser/parseprojectjob.cpp
<https://git.reviewboard.kde.org/r/119642/#comment44655>

    please add a comment that says what you mentioned in the commit message, i.e. enforce a reload to ensure the include paths etc. are properly picked up



language/backgroundparser/parseprojectjob.cpp
<https://git.reviewboard.kde.org/r/119642/#comment44657>

    here and below: space after for/if



language/backgroundparser/parseprojectjob.cpp
<https://git.reviewboard.kde.org/r/119642/#comment44656>

    here and below, the braces are wrong - put them on the same line as the for/if



shell/projectcontroller.cpp
<https://git.reviewboard.kde.org/r/119642/#comment44658>

    this changeset looks wrong, I mean why was the comment removed? also, you should trigger the forceupdate here as well, no?


- Milian Wolff


On Aug. 7, 2014, 10:33 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119642/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 10:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> First queue active document with highest priority, then currently opened files and everything else. That way we get active document parsed first of all.
> Also forcefully reparse all opened files to make sure they have valid include directories (otherwise sometimes those files won't be parsed properly)
> 
> 
> Diffs
> -----
> 
>   language/backgroundparser/parseprojectjob.cpp 7f430d7 
>   shell/projectcontroller.cpp 994a737 
> 
> Diff: https://git.reviewboard.kde.org/r/119642/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140807/3fc11de9/attachment.html>