Review Request 119644: Delay setting top-context features for top context.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119644/#review63977
-----------------------------------------------------------

Ship it!


I think this patch is correct, but could you please think of writing a unit test for this?

- Milian Wolff


On Aug. 7, 2014, 11:31 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119644/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 11:31 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
>  setFeatures() for TopDUContext sets those features for ParsingEnvironmentFile too. And then when we check parsingEnvironmentFile()->featuresSatisfied(features) we always get true and as a result we get function bodies not parsed (see CXTranslationUnit_SkipFunctionBodies)
> 
> 
>  The patch itself is very trivial, but I'm not familiar with the code at all, so please check whether it's the right way/place to fix it!
> 
> 
> Diffs
> -----
> 
>   duchain/clanghelpers.cpp b1ee091 
> 
> Diff: https://git.reviewboard.kde.org/r/119644/diff/
> 
> 
> Testing
> -------
> 
> All passed tests still pass.
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140807/51fec9fa/attachment.html>