Review Request 119192: Make shell scripts portable and stable

[Vadim Zhukov]

> On Июль 10, 2014, 10:48 д.п., Kevin Funk wrote:
> > Still not fully working:
> > ./util/kdev_format_source: 113: ./util/kdev_format_source: Syntax error: "fi" unexpected (expecting ";;")
> > 
> > By the way. @KDevelop devs: How is this script supposed to work at all?
> > 
> > When running the original version I get:
> > % bash ./util/kdev_format_source ./util/pushvalue.h
> > No tempfile given, formatting the original file
> > found /home/krf/devel/src/kdevplatform/format_sources
> > matched without wildcard, using command plugins/patchreview/libdiff2/* plugins/patchreview/settings/* plugins/quickopen/expandingtree/* 
> > ./util/kdev_format_source: line 123: plugins/patchreview/libdiff2/CMakeLists.txt: Permission denied
> > 
> > Am I doing something wrong?
> 
> Vadim Zhukov wrote:
>     Maybe they could be just dropped then?

So what's the decision? The last patch version was published 3 weeks ago, no feedback since then.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119192/#review62042
-----------------------------------------------------------


On Июль 10, 2014, 2:15 п.п., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119192/
> -----------------------------------------------------------
> 
> (Updated Июль 10, 2014, 2:15 п.п.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch makes provided scripts run on a generic Unix, and not only on bash-enabled ones. Also, some concepts were changed to more correct ones.
> 
> Patches are both applicable to stable and master branches.
> 
> Please note that I do not have commit rights.
> 
> 
> Diffs
> -----
> 
>   util/kdev_format_source 84434b1 
>   util/kdevplatform_shell_environment.sh 216e8c3 
> 
> Diff: https://git.reviewboard.kde.org/r/119192/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140806/831269c1/attachment-0001.html>