Review Request 117835: Now IDM (Includes/Defines manager) provides all types of includes/defines, not just user-specified. (kdevplatform)

[Aleix Pol Gonzalez]

> On April 29, 2014, 12:05 p.m., Aleix Pol Gonzalez wrote:
> > I think this change makes the development of project managers more complex for no reasons.
> > 
> > I don't think project managers should be aware of the includes you want to bypass to the language support.
> 
> Sergey Kalinichev wrote:
>     >I don't think project managers should be aware of the includes you want to bypass to the language support.
>     
>     Huh? I think I lost the thread... What are you talking about?

I'm saying that I don't think an implementation of a project manager should need to be aware of IDefinesAndIncludesManager. You can have the implementations of IDefinesAndIncludesManager to access the IBuildSystemManager interface or whatever the user defined.

To put it differently, what's the point of implementing a buildsystem manager without includes and defines?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117835/#review56868
-----------------------------------------------------------


On April 28, 2014, 11:03 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117835/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 11:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The changes include extending IDM interface and removing i/d notion from IBuildSystemManager interface.
> 
> 
> Diffs
> -----
> 
>   language/interfaces/idefinesandincludesmanager.h ab42444 
>   project/interfaces/ibuildsystemmanager.h 241b696 
> 
> Diff: https://git.reviewboard.kde.org/r/117835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140429/0bf33ccf/attachment.html>