Review Request 117886: Recognize components, properties, signals, slots and methods in plugin.qmltypes files

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117886/#review56929
-----------------------------------------------------------


Nice work! Just a few notes below, the only relevant one is the DelayedType thing.

For putting the modules into the right contexts, maybe that's not even necessary; as long as they are in *some* separate context, when you can find that, you can just add that context to the file where the import is. Importing things works like "pretend this context's contents would be right here" (that's what addImportedParentContext does), so you should be fine when you just create some context for Module / Component and then import the right one of those.


duchain/declarationbuilder.h
<https://git.reviewboard.kde.org/r/117886/#comment39689>

    What's the difference between those two, I guess one gets an integral type and one gets a type for a builtin class? Can you document it please?



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/117886/#comment39690>

    Does this crash when there's no such attribute? Just asking ;)



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/117886/#comment39691>

    auto? ;)



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/117886/#comment39692>

    I never used DelayedType, are you sure it does what you think it does?
    It is intended to be used for C++ templates, which is quite different from "this type was not yet parsed". Maybe it can be used for this purpose, I don't know, but it sounds a bit adventurous ;)
    Maybe just return mixed here?



tests/files/plugins.qml
<https://git.reviewboard.kde.org/r/117886/#comment39693>

    awesome!


- Sven Brauch


On April 29, 2014, 7:10 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117886/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 7:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> Sorry for the size of this patch, but most of the things added in this patch are needed in order for it to be unit-testable. This patch adds the following:
> 
> * A method that takes a QML type name ("int", "float", "bool" or any class name like "QObject") and returns the corresponding IntegralType, StructureType or DelayedType
> * Support for plugin.qmltypes files that declare QML components and their properties, methods, signals and slots (methods, signals and slots have their argument types recognized)
> * A new test file
> 
> This screenshot (http://steckdenis.be/static/images/kdev-js-qml-types.png) shows what KDevelop displays when I put my cursor on "Component". The component is correctly declared (using its name and its prototype), and its use is correctly detected (though this detection will come in a future patch). "Component" is highlighted instead of "name: "QAbstractItemModel"" because highlighting string literals was not pretty at all.
> 
> A future patch will add support for enumerations, then I will need to figure out how to correctly put all these declarations in the correct namespaces (each component comes with the domain name of the package in which it has to be registered).
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.h 2f7affc 
>   duchain/declarationbuilder.cpp 9fc2e6c 
>   tests/files/plugins.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117886/diff/
> 
> 
> Testing
> -------
> 
> I've added a testsuite for this patch, and it passes, even though it is quite minimal because there are still many things to do :-) .
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140429/38f26acf/attachment-0001.html>