Review Request 117885: Also return the SourceLocation of a QML attribute in getQMLAttribute

[Denis Steckelmacher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117885/
-----------------------------------------------------------

(Updated April 29, 2014, 6:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdev-qmljs


Description
-------

This patch changes Utils::getQMLAttribute so that it returns the value and the source location of an attribute. This is especially useful for code snippets like this:

Rectangle {
    id: my_rectangle
}

Before this patch, my_rectangle was left uncolored and Rectangle was used to represent the declaration of "my_rectangle". Now, Rectangle is left black and "my_rectangle" is rainbow-colored.


Diffs
-----

  duchain/declarationbuilder.cpp 5c2c090 
  duchain/helper.h bdcef3a 
  duchain/helper.cpp 0c258dd 

Diff: https://git.reviewboard.kde.org/r/117885/diff/


Testing
-------

The whole testsuite passes and manual testing shows that ids are correctly recognized.


Thanks,

Denis Steckelmacher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140429/97945aac/attachment.html>