Review Request 117836: Now IDM (Includes/Defines manager) provides all types of includes/defines, not just user-specified. (kdevelop)

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117836/
-----------------------------------------------------------

(Updated April 29, 2014, 8:04 p.m.)


Review request for KDevelop.


Changes
-------

Attached 2 backtraces.

Also you could reproduce the assert by opening any project and typing something in any file.


Repository: kdevelop


Description
-------

  Currently to retrieve i/d we use IBuildSystemManager, that's imo very strange, as I don't see any reason why e.g. builder() method and includes() should be in one interface? Language plugins obviously don't use the former... 
  Also not all project manager use i/d functionality (e.g. Custom build system doesn't).
  Finally, with that path applied it becomes simpler to retrieve i/d as now all information is accessible from one place.


Diffs
-----

  languages/cpp/includepathcomputer.cpp 74fcc16 
  languages/plugins/custom-definesandincludes/definesandincludesmanager.h bd560eb 
  languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp d1723d3 
  languages/plugins/custom-definesandincludes/kdevdefinesandincludesmanager.desktop.cmake 65b933f 
  projectmanagers/cmake/cmakemanager.h 19fc0c1 
  projectmanagers/cmake/cmakemanager.cpp 99e9e21 
  projectmanagers/cmake/tests/cmakemanagertest.cpp 4e83175 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.h 0798602 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp db194a4 
  projectmanagers/custommake/custommakemanager.h 6946e62 
  projectmanagers/custommake/custommakemanager.cpp 346c8cd 

Diff: https://git.reviewboard.kde.org/r/117836/diff/


Testing
-------

Everything language/project related still passes (except cmakeprojectvisitortest, but it doesn't work for me either way.)


File Attachments (updated)
----------------

backtreces.tar.gz
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/29/f68a81a0-292b-4808-a3ab-5fa7f1348b7e__backtreces.tar.gz


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140429/f4f6dd30/attachment.html>