Review Request 117836: Now IDM (Includes/Defines manager) provides all types of includes/defines, not just user-specified. (kdevelop)

Sergey Kalinichev at
Tue Apr 29 11:21:25 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated April 29, 2014, 3:21 p.m.)

Review request for KDevelop.


Fixed the issues.

Repository: kdevelop

Description (updated)

  Currently to retrieve i/d we use IBuildSystemManager, that's imo very strange, as I don't see any reason why e.g. builder() method and includes() should be in one interface? Language plugins obviously don't use the former... 
  Also not all project manager use i/d functionality (e.g. Custom build system doesn't).
  Finally, with that path applied it becomes simpler to retrieve i/d as now all information is accessible from one place.

Diffs (updated)

  languages/cpp/includepathcomputer.cpp 74fcc16 
  languages/plugins/custom-definesandincludes/definesandincludesmanager.h bd560eb 
  languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp d1723d3 
  languages/plugins/custom-definesandincludes/kdevdefinesandincludesmanager.desktop.cmake 65b933f 
  projectmanagers/cmake/cmakemanager.h 19fc0c1 
  projectmanagers/cmake/cmakemanager.cpp 99e9e21 
  projectmanagers/cmake/tests/cmakemanagertest.cpp 4e83175 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.h 0798602 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp db194a4 
  projectmanagers/custommake/custommakemanager.h 6946e62 
  projectmanagers/custommake/custommakemanager.cpp 346c8cd 



Everything language/project related still passes (except cmakeprojectvisitortest, but it doesn't work for me either way.)


Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list