Review Request 117835: Now IDM (Includes/Defines manager) provides all types of includes/defines, not just user-specified. (kdevplatform)

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117835/#review56734
-----------------------------------------------------------

Ship it!


Some small nitpicks, otherwise looks fine, I guess. Also, wouldn't it make sense to push more from the includepathcomputer into this interface, i.e. a generic interface that returns include paths and defines for a Path (instead of a ProjectBaseItem*)?


language/interfaces/idefinesandincludesmanager.h
<https://git.reviewboard.kde.org/r/117835/#comment39608>

    please document this. Who should implement this? What can I do with it?
    
    Also: please add a newline before the {



language/interfaces/idefinesandincludesmanager.h
<https://git.reviewboard.kde.org/r/117835/#comment39607>

    virtual ~Provider() = default;


- Milian Wolff


On April 28, 2014, 11:03 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117835/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 11:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The changes include extending IDM interface and removing i/d notion from IBuildSystemManager interface.
> 
> 
> Diffs
> -----
> 
>   language/interfaces/idefinesandincludesmanager.h ab42444 
>   project/interfaces/ibuildsystemmanager.h 241b696 
> 
> Diff: https://git.reviewboard.kde.org/r/117835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140428/567da627/attachment.html>