Review Request 117763: Make the clang plugin reuse Includes and Defines interface

[Olivier Jean de Gaalon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117763/#review56533
-----------------------------------------------------------

Ship it!


Just one issue, and then Ship It, I'd say


clangparsejob.cpp
<https://git.reviewboard.kde.org/r/117763/#comment39453>

    You don't need to check if the item is valid?


- Olivier Jean de Gaalon


On April 25, 2014, 12:52 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117763/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 12:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Make the clang plugin reuse Includes and Defines interface
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp d940015 
>   duchain/parsesession.cpp f0ee15a 
> 
> Diff: https://git.reviewboard.kde.org/r/117763/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140425/98756ac8/attachment.html>