Review Request 117763: Make the clang plugin reuse Includes and Defines interface

[Olivier Jean de Gaalon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117763/#review56512
-----------------------------------------------------------



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/117763/#comment39425>

    If I understand correctly, clang isn't able to use multiple pch files directly, only through chaining (ie file1.pch is created using file2.pch...). I'm not sure what the effect of using multiple -include args will be, IIRC it just ignores them.
    
    In any case, this won't work for kdev-clang as anything coming from the pch won't exist in the resulting ast and thus won't be duchainified.
    
    In summary, I believe the pchInclude path should be the only -include argument, and that it should originally be derived from the IDI you wrote instead of .kdev_pch_include as is currently the case.
    
    I understand this is problematic from a UI perspective at least, but IMO it's not immediately clear to the user that it's even possible to add a pch using the IDI gui currently. I realize that oldcpp can handle multiple pch just fine, but I wonder if the pch shouldn't be a single separate entry.


- Olivier Jean de Gaalon


On April 25, 2014, 10:35 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117763/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 10:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Make the clang plugin reuse Includes and Defines interface
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp d940015 
>   duchain/parsesession.cpp f0ee15a 
> 
> Diff: https://git.reviewboard.kde.org/r/117763/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140425/f9f7f4b1/attachment-0001.html>