Review Request 117527: Added implement function completion to kdev-clang

[Milian Wolff]

> On April 22, 2014, 9:15 p.m., Milian Wolff wrote:
> > codecompletion/completionhelper.cpp, line 272
> > <https://git.reviewboard.kde.org/r/117527/diff/2/?file=267591#file267591line272>
> >
> >     why is this a list and then joined with an empty separator? Use a QString directly, no?
> 
> David Stevens wrote:
>     I assumed that join is more efficient that directly concatenating QStrings. Is that not true?

actually a very good idea, yes that sounds as if it could actually be faster indeed. leave it as is then but replace the .join("") with a .join(QString()).


> On April 22, 2014, 9:15 p.m., Milian Wolff wrote:
> > codecompletion/completionhelper.cpp, line 31
> > <https://git.reviewboard.kde.org/r/117527/diff/2/?file=267591#file267591line31>
> >
> >     QHash?
> 
> David Stevens wrote:
>     Based on my some quick google searches, it looks like QMap is faster than QHash for small numbers of string keys, since string comparisons are faster than string hashing. And I doubt it's very common to have a template with more than 3 or 4 members.

right yeah hm probably you are right here :) nevertheless its probably not important anyways as you say as its only very small containers and the difference is then negligible.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117527/#review56218
-----------------------------------------------------------


On April 25, 2014, 4:25 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117527/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 4:25 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Added implement function completion. This involved refactoring some code, so the diff is pretty large. The core of the implemenation occurs in lines 186-286 and lines 312-326 of completionhelper.cpp.
> 
> 
> Diffs
> -----
> 
>   codecompletion/CMakeLists.txt e72f5ba 
>   codecompletion/completionhelper.h PRE-CREATION 
>   codecompletion/completionhelper.cpp PRE-CREATION 
>   codecompletion/context.h b328ae9 
>   codecompletion/context.cpp 9f92251 
>   codecompletion/overridecompletionhelper.h fc34275 
>   codecompletion/overridecompletionhelper.cpp aff69f6 
>   tests/codecompletiontest.h bacab65 
>   tests/codecompletiontest.cpp 2ae64c6 
> 
> Diff: https://git.reviewboard.kde.org/r/117527/diff/
> 
> 
> Testing
> -------
> 
> Manual and unit tests.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140425/9262686e/attachment-0001.html>