Review Request 115506: A fix so CMake errors link to the proper file.

Todd Nowacki nowacki724 at gmail.com
Thu Apr 24 09:09:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115506/
-----------------------------------------------------------

(Updated April 24, 2014, 9:09 a.m.)


Status
------

This change has been discarded.


Review request for KDevelop.


Bugs: 321982
    http://bugs.kde.org/show_bug.cgi?id=321982


Repository: kdevplatform


Description
-------

Before, it was assumed that the build directory was an immediate child of the source directory.

Now, we iterate through each project (via the project controller) to find a project with a matching build directory and grab the source directory from that project. 


Diffs
-----

  outputview/CMakeLists.txt b15d640f4486e863dd90caa8560f9c332cc66810 
  outputview/outputfilteringstrategies.cpp f2e65e115644d04d1bb362d31d30d149a8071d00 

Diff: https://git.reviewboard.kde.org/r/115506/diff/


Testing
-------

The search works for kdevelop and kdevplatform.

It should ideally be tested on a project where he build directory is not an immediate child of the source directory, but I did not have such a project at the time of posting this patch. 


Thanks,

Todd Nowacki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140424/54548378/attachment.html>


More information about the KDevelop-devel mailing list