Review Request 115506: A fix so CMake errors link to the proper file.

[Kevin Funk]

> On April 22, 2014, 9:55 p.m., Milian Wolff wrote:
> > cool - but can you also add a unit test somehow? that would be awesome!
> 
> Todd Nowacki wrote:
>     Do we want to ship it?
>     From the other discussion I thought we had decided that this was more of a bug with CMake than anything else.

Personally, I'd say abandon it. It's adding too much logic in the filtering strategies. I'd rather try fixing this upstream and patch CMake to print absolute paths.

I've sent another mail to the CMake mailing list regarding the issue a month ago, but apparently there's not much interest from their side wrt fixing this issue (there was no real feedback). I think it'd best to just prepare a patch for CMake and see if it's being accepted.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115506/#review56235
-----------------------------------------------------------


On Feb. 5, 2014, 10:37 p.m., Todd Nowacki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115506/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 10:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 321982
>     http://bugs.kde.org/show_bug.cgi?id=321982
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Before, it was assumed that the build directory was an immediate child of the source directory.
> 
> Now, we iterate through each project (via the project controller) to find a project with a matching build directory and grab the source directory from that project. 
> 
> 
> Diffs
> -----
> 
>   outputview/CMakeLists.txt b15d640f4486e863dd90caa8560f9c332cc66810 
>   outputview/outputfilteringstrategies.cpp f2e65e115644d04d1bb362d31d30d149a8071d00 
> 
> Diff: https://git.reviewboard.kde.org/r/115506/diff/
> 
> 
> Testing
> -------
> 
> The search works for kdevelop and kdevplatform.
> 
> It should ideally be tested on a project where he build directory is not an immediate child of the source directory, but I did not have such a project at the time of posting this patch. 
> 
> 
> Thanks,
> 
> Todd Nowacki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140424/3abd37f4/attachment-0001.html>