Review Request 117527: Added implement function completion to kdev-clang

David Stevens dgedstevens at gmail.com
Tue Apr 22 02:21:38 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117527/
-----------------------------------------------------------

(Updated April 22, 2014, 2:21 a.m.)


Review request for KDevelop.


Changes
-------

Fixed a bug where toplevel functions wouldn't be completed. Added support for variadic functions and const methods.


Repository: kdev-clang


Description
-------

Added implement function completion. This involved refactoring some code, so the diff is pretty large. The core of the implemenation occurs in lines 186-286 and lines 312-326 of completionhelper.cpp.


Diffs (updated)
-----

  codecompletion/CMakeLists.txt e72f5ba 
  codecompletion/completionhelper.h PRE-CREATION 
  codecompletion/completionhelper.cpp PRE-CREATION 
  codecompletion/context.h b328ae9 
  codecompletion/context.cpp 9f92251 
  codecompletion/overridecompletionhelper.h fc34275 
  codecompletion/overridecompletionhelper.cpp aff69f6 
  tests/codecompletiontest.h bacab65 
  tests/codecompletiontest.cpp 2ae64c6 

Diff: https://git.reviewboard.kde.org/r/117527/diff/


Testing
-------

Manual and unit tests.


Thanks,

David Stevens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140422/5d784254/attachment.html>


More information about the KDevelop-devel mailing list