Review Request 117612: Make ExpressionVisitor inherit from DynamicLanguageExpressionVisitor

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117612/#review55966
-----------------------------------------------------------

Ship it!


Looks nice, except for the one thing I don't understand. Thanks!


duchain/expressionvisitor.h
<https://git.reviewboard.kde.org/r/117612/#comment39002>

    What's this for? Sorry, I'm C++ illiterate and I don't know what it does in this context. Will the function be hidden otherwise?


- Sven Brauch


On April 17, 2014, 12:16 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117612/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 12:16 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> Sven Brauch has just added a DynamicLanguageExpressionVisitor class in KDevPlatform. This class contains several useful methods for dynamic language expression visitors, such as everything needed to keep track of the current type and current declaration, and also a method that can be used to build a mixed integral type (very nice addition!)
> 
> This patch makes ExpressionVisitor inherit from DynamicLanguageExpressionVisitor. The patch is fairly simple as it removes one setType() method and changes every use of setType to encounter(). I also had to change QmlJS::findDeclaration, as it took a DUContextPointer parameter. The problem was that the constructor of DUContextPointer requires a DUContext*, while DynamicLanguageExpressionVisitor only provides a const DUContext*.
> 
> 
> Diffs
> -----
> 
>   duchain/expressionvisitor.h bd82ff2 
>   duchain/expressionvisitor.cpp a7e0ba6 
>   duchain/helper.h 23a6d0e 
>   duchain/helper.cpp 935ccd8 
>   duchain/usebuilder.cpp 154a4d3 
> 
> Diff: https://git.reviewboard.kde.org/r/117612/diff/
> 
> 
> Testing
> -------
> 
> All the existing unit tests pass with the simplified expression visitor.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140417/b77ba811/attachment-0001.html>