Review Request 117535: If a function contains several return statements of different types, build an UnsureType

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117535/#review55584
-----------------------------------------------------------


See comments below ;)


duchain/helper.h
<https://git.reviewboard.kde.org/r/117535/#comment38680>

    Maybe a similar function should instead go into DUChainUtils? Ruby has borrowed my implementation too, so now we have it in three places ...
    
    I'd say this should be kdevplatform/language/duchain/duchainutils.h, in a cleaned-up form of what python has. I will see that I can do that.



duchain/helper.cpp
<https://git.reviewboard.kde.org/r/117535/#comment38681>

    While you're at it, make the second argument const



duchain/helper.cpp
<https://git.reviewboard.kde.org/r/117535/#comment38682>

    Definitely not the right thing to do. Don't discard the information you have. You can either do unsure(mixed, T) or just T, I would go for the latter, but definitely not just mixed.
    
    mixed is the analyzer admitting complete defeat and is entirely useless. Avoid it at all costs.


- Sven Brauch


On April 13, 2014, 12:17 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117535/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 12:17 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> This patch introduces the mergeTypes() function, based on the same function in kdev-python. Its behavior differs from the Python one in several aspects, though:
> 
> * Mixed types absorb other types (the function never returns "unsure(mixed, int)", but simply "mixed"). I'm not sure that it is the right thing to do, but I think that the "mixed" type is generally used to represent an unknown type. The user therefore gains no information by knowing that a function returns "anything, and this anything can sometimes be an int".
> * The function makes more assumptions than the Python one. For instance, I know that the second type passed to it is never NULL, and that the function will be used to add a return type to a function or to add a type of a variable.
> 
> This function is used to merge the type of all the return statements of a function. This way, the user can know when a function may return values of different types. A future patch will also use this function to deduce the type of variables using assignments to them. 
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp fe131ce 
>   duchain/helper.h 23a6d0e 
>   duchain/helper.cpp 3ffdd56 
>   tests/files/helloworld.js 1ce3815 
> 
> Diff: https://git.reviewboard.kde.org/r/117535/diff/
> 
> 
> Testing
> -------
> 
> 4 tests have been added. They test the basic features of mergeTypes and some corner cases (how voids should be handled, different return statements having the same type and how mixed should take precedence over other types).
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140413/53d2872e/attachment.html>