Review Request 113119: Replace libgraph with libcgraph to be compatible with GraphViz 2.30+

Sven Brauch svenbrauch at googlemail.com
Wed Apr 2 22:03:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113119/#review54901
-----------------------------------------------------------


I pushed this after talking to the patch author in IRC. Since it fixes breakage and was found to be ok, I think it makes sense to not let it rot, even if it is not sufficient to make the plugin usable again.

- Sven Brauch


On April 2, 2014, 10:01 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113119/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 10:01 p.m.)
> 
> 
> Review request for KDevelop and Sandro Andrade.
> 
> 
> Repository: kdev-control-flow-graph
> 
> 
> Description
> -------
> 
> libgraph is deprecated in GraphViz 2.30 and above. It's replaced with libcgraph. Fedora 19 ships with GraphViz 2.30.1 and thus doesn't include libgraph so it wasn't possible to compile. Luckily there was required only very little changes.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0904ba858da16c58ca637947ba7e698ddaf341bf 
>   cmake/modules/FindGraphViz.cmake c542b05a06e90068ff8a2812c611f6bce2288913 
>   dotcontrolflowgraph.cpp 7d803a5e2992fbb9def3f7f09a50599fb7c15772 
> 
> Diff: https://git.reviewboard.kde.org/r/113119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140402/115a720e/attachment.html>


More information about the KDevelop-devel mailing list