Review Request 112787: Completion filtering: Abbreviation expansion and "contains" filtering

[Vlas Puhov]

> On Sept. 30, 2013, 3:49 p.m., Vlas Puhov wrote:
> > 1. Neither "contains" filtering nor abbreviation expansion works for UPPER_CASE_ENTRIES.
> > 2. e.g. given entry: cursorPositionCoordinates
> > If I type position - everything is ok, but if add c: positionc - suggestion disappears, probably it shouldn't happen.
> > 
> > Otherwise it works great!!
> >
> 
> Sven Brauch wrote:
>     1 is a bit of a corner case, I'm not sure how we can support that in all obscure forms. Like upper_CAsE_eNTRIES, what do we do now? Does UCAE match this?
>     
>     2 is a valid problem, the code I wrote now is a bit too simple to catch all cases. I'll update it shortly.

I don't know what about upper_CAsE_eNTRIES (I've never seen anything like this before...), but UPPER_CASE_ENTRIES are used very often e.g. like an enum element or a macros, so it should work at least for these cases. 


- Vlas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112787/#review41024
-----------------------------------------------------------


On Sept. 29, 2013, 4:18 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112787/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 4:18 p.m.)
> 
> 
> Review request for Kate and KDevelop.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> (I'll put this up here for discussion, I think a bit more work is required before submission.)
> 
> This patch implements less restrictive rules for completion list filtering. Currently, an item is only displayed if it starts with the typed text. In addition to that, I'd like to allow:
> 
>  1) Abbreviation expansion; see first screnshot. This matches entries where the entered text matches the (beginning of) the camelCased or under_scored entry name's first letters.
> 
>  2) Match if the entry only contains the word. This probably needs a bit of thinking to not disrupt existing workflows. My current solution only uses this filter if the length of the entered text is 4 or more characters.
> 
> What do you think?
> 
> Do you think this should be configurable?
> 
> 
> Diffs
> -----
> 
>   part/completion/katecompletionmodel.h 088ac19 
>   part/completion/katecompletionmodel.cpp accd5e4 
> 
> Diff: http://git.reviewboard.kde.org/r/112787/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> abbreviation expansion
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/matching.png
> "contains" matching (if length > 3)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/matching1.png
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130930/a9e98a2c/attachment.html>