Review Request 112787: Completion filtering: Abbreviation expansion and "contains" filtering

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112787/
-----------------------------------------------------------

(Updated Sept. 29, 2013, 12:18 p.m.)


Review request for Kate and KDevelop.


Changes
-------

Next revision, I think it's quite good now.

* Implement Vlas' suggestion
* Fix a bug which made the completion list flicker in a weird way when there were Best Matches

It'd be great if someone else, too, could test it a bit, to make sure nothing breaks. ;)


Description
-------

(I'll put this up here for discussion, I think a bit more work is required before submission.)

This patch implements less restrictive rules for completion list filtering. Currently, an item is only displayed if it starts with the typed text. In addition to that, I'd like to allow:

 1) Abbreviation expansion; see first screnshot. This matches entries where the entered text matches the (beginning of) the camelCased or under_scored entry name's first letters.

 2) Match if the entry only contains the word. This probably needs a bit of thinking to not disrupt existing workflows. My current solution only uses this filter if the length of the entered text is 4 or more characters.

What do you think?

Do you think this should be configurable?


Diffs (updated)
-----

  part/completion/katecompletionmodel.h 088ac19 
  part/completion/katecompletionmodel.cpp accd5e4 

Diff: http://git.reviewboard.kde.org/r/112787/diff/


Testing
-------


File Attachments
----------------

abbreviation expansion
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/matching.png
"contains" matching (if length > 3)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/matching1.png


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130929/9ded8ff8/attachment.html>