Review Request 112949: Create private slots, automatically

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112949/
-----------------------------------------------------------

(Updated Sept. 26, 2013, 10:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Description
-------

I know it's not a big issue, but it still kept annoying me. Whenever we automatically create a slot, we are creating it as a public slot.

This is a weird behavior because a slot doesn't necessarily need to be public to be called from connect. Also when doing things automatically it's always good to be a bit conservative. :)


Diffs
-----

  languages/cpp/codecompletion/implementationhelperitem.cpp a9a5f90 

Diff: http://git.reviewboard.kde.org/r/112949/diff/


Testing
-------

Seems to work.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130926/7c91ece0/attachment.html>