Review Request 112949: Create private slots, automatically

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112949/#review40852
-----------------------------------------------------------

Ship it!


I agree.

Even cooler might be to offer two options, for creating a public or a private slot.

- Sven Brauch


On Sept. 26, 2013, 12:54 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112949/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 12:54 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I know it's not a big issue, but it still kept annoying me. Whenever we automatically create a slot, we are creating it as a public slot.
> 
> This is a weird behavior because a slot doesn't necessarily need to be public to be called from connect. Also when doing things automatically it's always good to be a bit conservative. :)
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/implementationhelperitem.cpp a9a5f90 
> 
> Diff: http://git.reviewboard.kde.org/r/112949/diff/
> 
> 
> Testing
> -------
> 
> Seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130926/dbb98d74/attachment.html>