Review Request 112917: Add support for Trait declarations, as introduced in PHP 5.4

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112917/#review40796
-----------------------------------------------------------



duchain/builders/predeclarationbuilder.cpp
<http://git.reviewboard.kde.org/r/112917/#comment29992>

    Just lock; the old stuff is superfluous nowadays 



duchain/builders/predeclarationbuilder.cpp
<http://git.reviewboard.kde.org/r/112917/#comment29993>

    This should also be done outside the lock being held to reduce lock contention 


- Milian Wolff


On Sept. 24, 2013, 1:30 p.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112917/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 1:30 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Add support for Trait declarations, as introduced in PHP 5.4.
> 
> This depends on https://git.reviewboard.kde.org/r/112916/
> 
> 
> Diffs
> -----
> 
>   completion/context.cpp d7bfd4ccec4206064ae56687057e235dbdca9dc8 
>   duchain/builders/contextbuilder.h 18ed3900a10a7a26c0d3b71c0dc76a89f67046fe 
>   duchain/builders/contextbuilder.cpp 7359ea2cc70ce1577f7189e0f1cdc1224b913f79 
>   duchain/builders/declarationbuilder.h e7f6f8cd0478bcaeae21ea39ae634881537d50be 
>   duchain/builders/declarationbuilder.cpp b5c813881cf94b376e173de200f476660d6c3b55 
>   duchain/builders/predeclarationbuilder.h 344ea5324a9ba7f1aad085cacf8396bbef16312f 
>   duchain/builders/predeclarationbuilder.cpp bae6576c13c14b820e19a2ef384cbc0a12245dff 
>   duchain/builders/typebuilder.h 18375ed1bbd256a0faba51c1cb22a3c689ce2391 
>   duchain/builders/typebuilder.cpp 6bcfa900ad67633a2c0ad0c422c370709126c379 
>   duchain/declarations/classdeclaration.cpp fbd69326781bb84c6115e944a1b518ef9cb516cf 
>   duchain/navigation/declarationnavigationcontext.cpp 646b8695613a1f703b0dbb113d8cd674c20a2abd 
>   duchain/tests/expressionparser.h 16b2408925b46814c48f147d4e128cf08dba7594 
>   duchain/tests/expressionparser.cpp 26738120dd78b77371e1f89ad73974da6cdbcbc0 
>   parser/php.g e07570fd495b14771c96b071f4d9865bad37f263 
>   parser/phplexer.cpp e17a54ff7fdff20fd35b4cff955dc228416b3ac8 
> 
> Diff: http://git.reviewboard.kde.org/r/112917/diff/
> 
> 
> Testing
> -------
> 
> make test, checked several example php files for correct parsing
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130925/e16420c3/attachment.html>