Review Request 112078: Creates a new file when trying to open a nonexistent file

lycantrophe li lycantrophe at lambda.is
Sat Sep 21 21:47:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112078/
-----------------------------------------------------------

(Updated Sept. 21, 2013, 9:47 p.m.)


Review request for KDevelop.


Changes
-------

Simply removes the check if the file does exist.

A later version of Kate will post a message if it creates a file through open semantics. This makes it unnecessary to handle these things in KDevelop, which makes this patch work.


Description
-------

Removes the check if a file exists (KIO::NetAccess::exists()) so that the following routines will create the file instead of just attempting to open it.


This addresses bug 322678.
    http://bugs.kde.org/show_bug.cgi?id=322678


Diffs
-----

  shell/documentcontroller.cpp 4fd2819 

Diff: http://git.reviewboard.kde.org/r/112078/diff/


Testing
-------

Tested both opening and creating files through the open file dialogue. Confirmed that creating files with File->New works as well.


File Attachments (updated)
----------------

open-create-file.patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/21/open-create-file.patch


Thanks,

lycantrophe li

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130921/f0e8f00c/attachment.html>


More information about the KDevelop-devel mailing list