Review Request 112590: Fix todo marker words and detailed completion settings not persistent across application restart.

[Nicolai Hähnle]

On Mon, Sep 9, 2013 at 1:11 PM, Vlas Puhov <vlas.puhov at mail.ru> wrote:
> I don't understand how can config file contain an int that does not fall into the range? It
> could only happen if you edit config file manually. But then you should know exactly what
> you're doing, otherwise you can break anything. And if something goes wrong YOU are the
> one who responsible for it. And the same goes for any setting, not just completionLevel.
> Anyway I don't think it's a good idea to change settings manually.

Perhaps you _can_ break anything with manual configuration changes,
but you _shouldn't be able to_ break anything with manual
configuration changes.

In other words: It may well be the case that manual configuration
changes cause terrible breakage today, perhaps up to crashes in
KDevelop. However, that should be considered a _bug_.

In this case, an enum should not end up being set to an undefined
value, because that can lead to bad behavior including crashes down
the line. If that happens, the user will blame KDevelop for it, even
if it was caused by a manual change to configuration files. And you
know what? The user would be _right_ to blame KDevelop. Crashes are
never okay.

Cheers,
Nicolai
-- 
Lerne, wie die Welt wirklich ist,
aber vergiss niemals, wie sie sein sollte.