Review Request 112590: Fix todo marker words and detailed completion settings not persistent across application restart.

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112590/#review39603
-----------------------------------------------------------


Ah, turns out that I'm the one that misread the code. I mixed up CCSettings (the KConfigSkeleton) and CompletionSettings (the API for plugins to access these settings)


shell/completionsettings.h
<http://git.reviewboard.kde.org/r/112590/#comment29185>

    You should not cast integers read from the config file like this. What happens if the config file contains an int that does not fall into the range used for the enum? IMO having the individual flags as separate boolean entries in the config is also more readable inside the config file. So that should be kept, which means there needs to be code added to actually change those boolean members in the ccpreferences class when another entry is selected.



shell/settings/ccpreferences.cpp
<http://git.reviewboard.kde.org/r/112590/#comment29184>

    As I said above, this should be connecting to a custom slot which updates the 3 bools related to the level and then emits a settings-changed signal.



shell/settings/ccpreferences.cpp
<http://git.reviewboard.kde.org/r/112590/#comment29183>

    I don't think thats the reason, its rather that the CompletionSettings class exposes all these settings to plugins and hence needs to be updated manually in case the config changes.


- Andreas Pakulat


On Sept. 8, 2013, 3:05 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112590/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2013, 3:05 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CCPreferences class is written with use of KCModule, so all setting can be saved/loaded automatically. For that widget's names should start with kcfg_ prefix, but neither todoMarkerWords nor completionDetail had one, so this feature didn't work.
> 
> 
> This addresses bug 324510.
>     http://bugs.kde.org/show_bug.cgi?id=324510
> 
> 
> Diffs
> -----
> 
>   shell/settings/ccpreferences.cpp 0347fc6 
>   shell/settings/ccpreferences.h 4ecf623 
>   shell/settings/ccconfig.kcfg 1bc89b1 
>   shell/completionsettings.cpp 6b6adf6 
>   shell/completionsettings.h b3f28ce 
>   shell/settings/ccsettings.ui 64d24e2 
> 
> Diff: http://git.reviewboard.kde.org/r/112590/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130908/7e29ac52/attachment.html>