Review Request 112582: Fix build on big endian plattforms

Aleix Pol Gonzalez aleixpol at kde.org
Sat Sep 7 20:26:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112582/#review39545
-----------------------------------------------------------

Ship it!


Makes sense, looks straightforward enough to me.

Thanks!

- Aleix Pol Gonzalez


On Sept. 7, 2013, 8:25 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112582/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2013, 8:25 p.m.)
> 
> 
> Review request for KDevelop and Friedrich W. H. Kossebau.
> 
> 
> Description
> -------
> 
> The Kasten header files
> * <structurestoolviewfactory.h>
> * <structurestoolfactory.h>
> are not available on big endian plattforms. The compile guard variable BIG_ENDIAN already ensures that the structures tool view is not created on big endian plattforms. This patch also simply excludes the headers for this plattform, too.
> 
> 
> Diffs
> -----
> 
>   utils/okteta/oktetaplugin.cpp 409111f 
> 
> Diff: http://git.reviewboard.kde.org/r/112582/diff/
> 
> 
> Testing
> -------
> 
> Built successfully.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130907/a56f83f3/attachment.html>


More information about the KDevelop-devel mailing list