Review Request 113473: Project Manager filter delay
Milian Wolff
mail at milianw.de
Mon Oct 28 18:43:52 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113473/#review42548
-----------------------------------------------------------
Sorry, but I think this is a waste of time. We should really just get rid of the project filter, it's a bad solution to the filtering problem imo.
Either use QuickOpen if you want to find a file, or use the new project filter to exclude items from your project tree. This in-between solution should be removed.
- Milian Wolff
On Oct. 28, 2013, 6:26 p.m., Eugene Agafonov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113473/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 6:26 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Project Manager's filter triggers every time when user hits the key. It became annoying with big projects once filter update may takes a noticible time.
>
> This patch implements a delay (1 sec in current implementation) between the user stops typing and filter update.
>
> The delay is implemented in ProjectManagerFilterAction so neither ProjectProxyMorel nor ProjectManager view is touched by this patch. ProjectManagerFilterAction's interface is not changed as well.
>
>
> Diffs
> -----
>
> plugins/projectmanagerview/projectmanagerview.h 020d24fcb71a6ea6a73effe62d5b3668060eab3f
> plugins/projectmanagerview/projectmanagerview.cpp fbec9add4035c4ffd4e3e28a4acd7c75d420ddc6
>
> Diff: http://git.reviewboard.kde.org/r/113473/diff/
>
>
> Testing
> -------
>
> Build and test on master branches with my dayly-work projects (10+ projects in single sessions, 5000+files of different types)
>
>
> Thanks,
>
> Eugene Agafonov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131028/381ceb35/attachment-0001.html>
More information about the KDevelop-devel
mailing list