Review Request 113445: Fix abstract method support for traits.

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113445/#review42391
-----------------------------------------------------------

Ship it!


Looks good, in general you don't necessarily need to create a new review request for fixing an obvious bug in your previous patch.
Can you submit this yourself?

- Sven Brauch


On Oct. 26, 2013, 10:03 a.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113445/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2013, 10:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> I missed in my initial implementation that traits do support abstract method declarations. Hotfix :)
> 
> 
> Diffs
> -----
> 
>   duchain/builders/declarationbuilder.cpp 93f987a192d99377a3f993f8be19c1616f94c49a 
>   duchain/tests/expressionparser.h f9bceefc73b83511ac375eb41d8ebd96e1ef387d 
>   duchain/tests/expressionparser.cpp 699b2b025dc6a6d69858624136dd1a396fe2ffaf 
> 
> Diff: http://git.reviewboard.kde.org/r/113445/diff/
> 
> 
> Testing
> -------
> 
> Sample files, unit tests
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131026/1d095d4c/attachment.html>