Review Request 113323: Change size of vcs eventWidget

[Morten Volden]

> On Oct. 20, 2013, 8:04 a.m., Kevin Funk wrote:
> > Personally, I like it a lot better. As a follow up change, one could also disable the two bottom views in case no revision is selected.

Updated the patch to disable the two bottom views when no event is selcected.


- Morten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113323/#review42000
-----------------------------------------------------------


On Oct. 20, 2013, 7:51 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113323/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2013, 7:51 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Whenever I use show history on a given file I find myself always resizing the eventWidget in order to see more of the history of commit messages. This patch changes the width of the widget to make a little more of the list visible. 
> 
> Edit:
> This patch now removes the labels from the widget to give more room to the actual content.
> 
> 
> Diffs
> -----
> 
>   vcs/widgets/vcseventwidget.cpp b0ba603 
>   vcs/widgets/vcseventwidget.ui fe5d6cb 
> 
> Diff: http://git.reviewboard.kde.org/r/113323/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> File Attachments
> ----------------
> 
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/17/25dee8b5-dc2f-47a9-a47e-7f7541e34551__eventview_before.png
> After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/17/c29dc49b-9011-4fdc-be2b-a7a6a3180876__eventview_minimumsize_914.png
> After Removed labels
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/18/b623ce04-db06-45a5-9441-005306994006__eventview_minimumsize_814_no_labels.png
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131020/5e717893/attachment.html>