Review Request 113264: Patch for Bug 273385 : Provide a shortcut for switching focus between split views

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113264/#review41817
-----------------------------------------------------------



shell/mainwindow_actions.cpp
<http://git.reviewboard.kde.org/r/113264/#comment30531>

    Spaces between '='



shell/mainwindow_p.cpp
<http://git.reviewboard.kde.org/r/113264/#comment30532>

    Use "&Next Split View", same applies to the other human-readable strings. Append "View" everywhere.


Looks good otherwise.

- Kevin Funk


On Oct. 16, 2013, 8:38 a.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113264/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 8:38 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Patch for Bug 273385 : Provide a shortcut for switching focus between split views
> 
> Provided a shortcut (key combination as well as on menu option) for switching between split views.Implemented the same by providing shortcut (Ctrl + Shift + P for moving to previous split and Ctrl + Shift + N for moving to next split) along with menu options in Window drop-down menu
> 
> 
> Diffs
> -----
> 
>   shell/mainwindow_actions.cpp 8ef2278 
>   shell/mainwindow_p.h 2cd0102 
>   shell/mainwindow_p.cpp 82d7897 
> 
> Diff: http://git.reviewboard.kde.org/r/113264/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested successfully on my local machine
> 
> 
> File Attachments
> ----------------
> 
> Screenshot for new options added in Window menu
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/16/5eac53d7-c6e1-4b40-bda7-6087381f51d1__bug_273385.jpg
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131016/9cfc1281/attachment.html>