Review Request 113186: Bug 321008 - Program arguments edit should have a clear button

Aleix Pol Gonzalez aleixpol at kde.org
Thu Oct 10 10:32:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113186/#review41482
-----------------------------------------------------------



plugins/execute/nativeappconfig.cpp
<http://git.reviewboard.kde.org/r/113186/#comment30327>

    Indendation looks wrong...


- Aleix Pol Gonzalez


On Oct. 10, 2013, 9:59 a.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113186/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 9:59 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> 
> Patch for Bug 321008 - Program arguments edit should have a clear button 
> 
> Added a clear text button in program arguments line edit (Run -> Configure Launches... -> Arguments) .
> 
> 
> Diffs
> -----
> 
>   plugins/execute/nativeappconfig.cpp f29beab 
> 
> Diff: http://git.reviewboard.kde.org/r/113186/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested successfully on my local machine. Able to clear arguments with clear text button.
> 
> 
> File Attachments
> ----------------
> 
>  Screenshot for original Argument Field
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/10/fd1b1c27-593c-45b9-8597-cdfd1e817253__old_arg_lineedit.png
> Screenshot for modified argument field
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/10/6e387c8c-951c-4169-a255-73c7e3e8564a__new_arg_lineedit.jpg
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131010/e856786b/attachment.html>


More information about the KDevelop-devel mailing list