Review Request 113092: Patch for Bug 319011 - Difficult to view full plugin description (Utilities and Version Control Plugins)

[Meenakshi Khorana]

> On Oct. 4, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote:
> > plugins/documentview/kdevdocumentviewplugin.cpp, line 40
> > <http://git.reviewboard.kde.org/r/113092/diff/1/?file=199153#file199153line40>
> >
> >     I'd recommend not starting all descriptions with "This plugin...".
> >     It's redundant.

I have used the same string as given in existing .desktop file. Please suggest if the same needs to be changed.


- Meenakshi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113092/#review41207
-----------------------------------------------------------


On Oct. 4, 2013, 9:25 a.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113092/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 9:25 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Patch for Bug 319011 - Difficult to view full plugin description
> 
> Improve plugin description(utilites and version control plugins), which is shown in the About dialog.
>     
> Reuse the wording from the .desktop file which is more helpful.
> 
> 
> Diffs
> -----
> 
>   plugins/vcschangesview/vcschangesviewplugin.cpp 7601b51 
>   plugins/switchtobuddy/switchtobuddyplugin.cpp d46334c 
>   plugins/snippet/snippetplugin.cpp e49310d 
>   plugins/konsole/kdevkonsoleviewplugin.cpp c018e19 
>   plugins/grepview/grepviewplugin.cpp 53f466a 
>   plugins/externalscript/externalscriptplugin.cpp 49db75a 
>   plugins/documentview/kdevdocumentviewplugin.cpp eb434b6 
>   plugins/codeutils/codeutilsplugin.cpp 1afe512 
> 
> Diff: http://git.reviewboard.kde.org/r/113092/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested successfully on my local machine. Kdevelop is showing full description in About of Plugins.
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131004/54c6578e/attachment-0001.html>