Review Request 113030: Patch for Bug 319011 - Difficult to view full plugin description

[Meenakshi Khorana]

> On Oct. 3, 2013, 8:58 a.m., Milian Wolff wrote:
> > Thank you!
> > 
> > Note though how I reworded your commit message. Please use a format similar to this in the future. I.e. a short summary on one line, followed by more information in the following paragraph(s). Usually it's
> > 
> > ~~~
> > What does this do.
> > 
> > Why is this required.
> > How is it implemented.
> > ...
> > ~~~
> > 
> > Also note that to automatically close a bug, you need to use the BUG: ID format. Same for the review request with the REVIEW: ID line.
> > 
> > Cheers! Hope to see more patches from your side! Thanks!

Thanks Milian. Noted the format. I ll use the same in future. 


- Meenakshi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113030/#review41158
-----------------------------------------------------------


On Oct. 3, 2013, 8:56 a.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113030/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 8:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> 
> Patch for Bug 319011 - Difficult to view full plugin description 
> 
> Have made changes to core plugins only but I have not made any changes to New Project Wizard and Project Manager View as i found their About to have relevant information. 
> 
> 
> Diffs
> -----
> 
>   plugins/classbrowser/classbrowserplugin.cpp 1212b63 
>   plugins/contextbrowser/contextbrowser.cpp 85e90b0 
>   plugins/dashboard/kdevprojectdashboard.cpp 7eb0816 
>   plugins/execute/executeplugin.cpp f3d4a8b 
>   plugins/filemanager/kdevfilemanagerplugin.cpp 04b4741 
>   plugins/filetemplates/filetemplatesplugin.cpp c34ab4a 
>   plugins/openwith/openwithplugin.cpp a64b08c 
>   plugins/quickopen/quickopenplugin.cpp 1779219 
> 
> Diff: http://git.reviewboard.kde.org/r/113030/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested successfully on my local machine. Kdevelop is showing full description in About of Plugins.
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131003/157913eb/attachment-0001.html>