Review Request 114164: environment settings: add ability to paste multiple items

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114164/#review44688
-----------------------------------------------------------


any input on my idea on not using a widget but just handling the paste event?


shell/settings/environmentwidget.cpp
<http://git.reviewboard.kde.org/r/114164/#comment31914>

    also add the braces to the conditional below, and please use the following style:
    
    if ( ) {
      ...
    }
    
    I know the rest of the document doesn't do that, but well, use it here please.



shell/settings/environmentwidget.cpp
<http://git.reviewboard.kde.org/r/114164/#comment31917>

    remove, the list will be empty and nothing be done anyways



shell/settings/environmentwidget.cpp
<http://git.reviewboard.kde.org/r/114164/#comment31915>

    also put this brace on the previous line



shell/settings/environmentwidget.cpp
<http://git.reviewboard.kde.org/r/114164/#comment31916>

    braces



shell/settings/environmentwidget.ui
<http://git.reviewboard.kde.org/r/114164/#comment31918>

    can you also show a screenshot please? the config page is already pretty crowded, maybe we need to restructure it now


- Milian Wolff


On Nov. 28, 2013, 12:29 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114164/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 12:29 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> In case where she already had configured env in shell, let her simply copy paste that env to configuration instead of tediously filling items one by one.
> 
> Not sure about the icon chosen for button.
> 
> 
> Diffs
> -----
> 
>   shell/settings/environmentwidget.h b464a4b 
>   shell/settings/environmentwidget.cpp ace016a 
>   shell/settings/environmentwidget.ui 4140c98 
> 
> Diff: http://git.reviewboard.kde.org/r/114164/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131128/99202631/attachment-0001.html>