Review Request 114164: environment settings: add ability to paste multiple items

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114164/#review44674
-----------------------------------------------------------


Instead of going through a separate widget, can't we simply catch the paste event and parse its string contents and add that?


shell/settings/environmentwidget.cpp
<http://git.reviewboard.kde.org/r/114164/#comment31899>

    add braces also to single-line conditionals



shell/settings/environmentwidget.cpp
<http://git.reviewboard.kde.org/r/114164/#comment31900>

    this and below can be merged:
    
    const QStringList lines = valueEdit->toPlainText().split("\n", ...);
    
    if it's empty, it will result in an empty list and nothing be done later on.



shell/settings/environmentwidget.cpp
<http://git.reviewboard.kde.org/r/114164/#comment31898>

    foreach(const QString& line, lines) {


- Milian Wolff


On Nov. 28, 2013, 10:03 a.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114164/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 10:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> In case where she already had configured env in shell, let her simply copy paste that env to configuration instead of tediously filling items one by one.
> 
> Not sure about the icon chosen for button.
> 
> 
> Diffs
> -----
> 
>   shell/settings/environmentwidget.h b464a4b 
>   shell/settings/environmentwidget.cpp ace016a 
>   shell/settings/environmentwidget.ui 4140c98 
> 
> Diff: http://git.reviewboard.kde.org/r/114164/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131128/c923caea/attachment.html>