Review Request 114084: Fix warning on __new__ method argument complain

Sven Brauch svenbrauch at googlemail.com
Tue Nov 26 21:24:19 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114084/#review44544
-----------------------------------------------------------


Half of your code is tab-indented. I will fix it, but please have an eye on that for future patches ;)

- Sven Brauch


On Nov. 26, 2013, 8:14 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114084/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 8:14 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> This patch fixes a warning on __new__ method argument complaining about the usage of self instead of cls.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp c711fd7 
>   duchain/tests/pyduchaintest.h 3edc7a8 
>   duchain/tests/pyduchaintest.cpp 615d1ee 
> 
> Diff: http://git.reviewboard.kde.org/r/114084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131126/c0c5c3eb/attachment.html>


More information about the KDevelop-devel mailing list