Review Request 113815: Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths"

[Meenakshi Khorana]

On Nov. 14, 2013, 4:03 p.m., Meenakshi Khorana wrote:
> > Okay, there are some issues with this patch. In theory you shouldn't touch the unresolvedincludeassistant.* files at all. You want to modify the behavior of the custom include paths widget, hence you need also need to touch just that.
> > 
> > Proposed change: Make the include path resolver a proper widget subclass, e.g. by providing also a .cpp and .h to the .ui. That's the pattern used when widgets have more complex logic inside. When you have the .cpp and .h file, move the logic you added to unresolvedincludeassistant.* to those newly created files. Signal/slot handling will get much easier when you do it this way.
> > 
> > The .cpp/.h/.ui pattern is a commonly used in Qt, you can see several examples in the kdevelop code base.
> > 
> > Does that make sense to you?
> 
> Meenakshi Khorana wrote:
>     If i wont touch unresolvedincludeassistant.*, where signal-slot mapping will go? 
>     
>     Can you please share some reference/example for the same.
> 
> Kevin Funk wrote:
>     That will go into custom_include_paths.cpp. You can connect to the clicked() signal in the yet-to-created CustomIncludePaths ctor and then just invoke a slot from the CustomIncludePaths class.
>     
>     http://techbase.kde.org/Development/Tutorials/Using_Qt_Designer#Using_the_UI_in_Your_Code is a good resource for that.
> 
> Kevin Funk wrote:
>     @Meenakshi: Feel free to join us in #kdevelop on Freenode (IRC), that way it's much easier to coordinate your work.
> 
> Meenakshi Khorana wrote:
>     Let me re-phrase my question... Do i have to create new ui file for a push button. As per my understanding, it should go to same ui file (custom_include_paths.ui) so if the button is defined in that ui file and "Setup Custom Include Path" dialog gets created in unresolvedclassassistant.cpp , how would my new class will get reference of same without touching unresolvedclassassistant.*
>     
>     I am stuck.. Please assist...

Can you please share some sample reference from existing kdevplatform/kdevelop code.


- Meenakshi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113815/#review43678
-----------------------------------------------------------


On Nov. 12, 2013, 11:50 a.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113815/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 11:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths" 
> 
> Integrated a folder browser to add custom include paths. User can add custom include paths on a button click and can view the added paths in plain text edit box.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/unresolvedincludeassistant.cpp 93a72d3 
>   languages/cpp/codegen/ui/custom_include_paths.ui 1a7c1ed 
>   languages/cpp/codegen/unresolvedincludeassistant.h b072265 
> 
> Diff: http://git.reviewboard.kde.org/r/113815/diff/
> 
> 
> Testing
> -------
> 
> Compiled and Tested successfully on local machine.
> 
> 
> File Attachments
> ----------------
> 
> Added open file dialog to custom include path
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/34ab7f7c-7aca-4c16-ab3f-add513c22f56__folder_browser_1.jpg
> Folder browser for selecting include paths
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/29a48901-93ee-40e7-9455-94acb648025e__folder_browser_2.jpg
> Added include paths will be visible to user in text edit
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/bf9fb89b-8e6e-49f8-b2b5-d865ded209b7__folder_browser_3.jpg
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131125/44541902/attachment-0001.html>